Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose libstd::sys_common::remutex #58612

Closed
ckaran opened this issue Feb 21, 2019 · 6 comments
Closed

Expose libstd::sys_common::remutex #58612

ckaran opened this issue Feb 21, 2019 · 6 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ckaran
Copy link

ckaran commented Feb 21, 2019

I just discovered that libstd::sys_common::remutex has the ReentrantMutex type, which is not exposed in std::sync. Can you please expose it in std::sync?

@Centril Centril added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Feb 21, 2019
@eggyal
Copy link
Contributor

eggyal commented Apr 8, 2021

See also #27738

@ckaran
Copy link
Author

ckaran commented Apr 9, 2021

@eggyal Thank you for link!

@SimonSapin
Copy link
Contributor

The fact that an implementation already exists inside std may help a little but it’s not the most important point. This would add non-trivial new API surface to the standard library, so it should likely go through the RFC process to consider questions like: what are the details of new APIs? What are their semantics? Why is making these choices preferable over alternatives? Is this a commonly-used enough primitive that is should be in the standard library rather than on crates.io? etc.

@eggyal
Copy link
Contributor

eggyal commented Apr 9, 2021

Is this a commonly-used enough primitive that is should be in the standard library rather than on crates.io?

Worth noting that @Amanieu's parking_lot crate provides a ReentrantMutex.

@ckaran
Copy link
Author

ckaran commented Apr 9, 2021

@SimonSapin I agree that it should go through the RFC process, if for no other reason than the fully refine the API and ensure it is exactly what we want to expose. Unfortunately, I don't have the time to push for it (too many deadlines at work right now).

@Mark-Simulacrum
Copy link
Member

Closing in favor of rust-lang/libs-team#193, which is tracking this API (and has an open PR).

@Mark-Simulacrum Mark-Simulacrum closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants