Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#65764 #65803

Closed
rust-highfive opened this issue Oct 25, 2019 · 3 comments
Closed

rls no longer builds after rust-lang/rust#65764 #65803

rust-highfive opened this issue Oct 25, 2019 · 3 comments
Assignees
@Xanewok
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #65764, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Manishearth, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Manishearth, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2019
@pnkfelix
Copy link
Member

triage: P-medium. Removing nomination label.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Oct 31, 2019
@Xanewok
Copy link
Member

Xanewok commented Oct 31, 2019

This is now stale - the most recent breakage has been fixed (#65944). The Clippy support in the RLS has not been updated after change in lint registration interface and so this specific breakage has been spontaneously fixed when Clippy broke (which meant broke Clippy integration was conditionally compiled-out).

All is working now, so closing this as stale.

@Xanewok Xanewok closed this as completed Oct 31, 2019
@Xanewok
Copy link
Member

Xanewok commented Oct 31, 2019

(@pnkfelix thanks for triage, it somehow slipped through the cracks for me...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xanewok Xanewok

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pnkfelix @Xanewok @rust-highfive