Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#67676 #67793

Closed
rust-highfive opened this issue Jan 2, 2020 · 2 comments · Fixed by rust-lang/miri#1138 or #67809
Closed

miri no longer builds after rust-lang/rust#67676 #67793

rust-highfive opened this issue Jan 2, 2020 · 2 comments · Fixed by rust-lang/miri#1138 or #67809
Assignees
@eddyb @RalfJung @oli-obk
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #67676, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @wesleywiser, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 2, 2020
@wesleywiser wesleywiser mentioned this issue Jan 2, 2020
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Jan 2, 2020

Reopening until the submodule is updated

@oli-obk oli-obk reopened this Jan 2, 2020
@pnkfelix
Copy link
Member

pnkfelix commented Jan 2, 2020

triage: P-medium. looks like its on way to being fixed, anyway.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Jan 2, 2020
@RalfJung RalfJung mentioned this issue Jan 2, 2020
Merged
@bors bors closed this as completed in c5840f9 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump rustc version to fix miri wesleywiser/miri
update miri RalfJung/rust
5 participants
@eddyb @pnkfelix @RalfJung @oli-obk @rust-highfive