Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnixDatagram: please support vectored send #68612

Open
joshtriplett opened this issue Jan 28, 2020 · 3 comments
Open

UnixDatagram: please support vectored send #68612

joshtriplett opened this issue Jan 28, 2020 · 3 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@joshtriplett
Copy link
Member

The UnixDatagram type provides send and send_to methods, but does not provide a vectored send operation. Such an operation is particularly helpful for datagrams, where separate send operations result in separate datagrams; a vectored send allows sending data from multiple buffers in a single datagram.

Given that UnixDatagram only runs on UNIX, where writev works just fine on a socket, such an operation could use writev; alternatively, this could use sendmsg, which supports supplying an iovec. sendmsg would also allow a vectored send_to operation.
@joshtriplett joshtriplett changed the title UnixDatagram does not support vectored send UnixDatagram: please support vectored send Jan 28, 2020
@joshtriplett joshtriplett added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 28, 2020
@Centril Centril added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jan 28, 2020
@sfackler
Copy link
Member

We don't support vectored send/recv on UdpSocket either currently - PRs welcome for both!

@joshtriplett
Copy link
Member Author

@sfackler Makes sense; UdpSocket filed separately as #68617.

@contrun contrun mentioned this issue Mar 11, 2020
Closed
@contrun
Copy link
Contributor

contrun commented Mar 11, 2020 •
edited
Loading

I have just added vectored send for send in #69915 . It seems that we don't have binding for sendmsg from libc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add send_vectored for unix socket contrun/rust
4 participants
@joshtriplett @Centril @sfackler @contrun