Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit trailing tokens in assert! #69531

Closed
adlerd opened this issue Feb 27, 2020 · 1 comment · Fixed by #69548
Closed

Revisit trailing tokens in assert! #69531

adlerd opened this issue Feb 27, 2020 · 1 comment · Fixed by #69548
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-future-incompatibility Category: Future-incompatibility lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@adlerd
Copy link

adlerd commented Feb 27, 2020

About 10 months ago it was necessary to permit typos to become temporary non-errors due to #60024 slipping into a stable release. Since #60039, the compiler has issued a "this will become an error" warning for a subset of accidentally-allowed uses (Playground):

fn main() {
    assert!(true "whatever");      // Intended: error. Currently: warning.
    assert!(true;);                // Intended: error. Currently: warning.
    assert!(true some extra junk); // Intended: error. Currently: error.
}

Version: 1.43.0 2020-02-26 nightly

Since the fix has been in for far longer than the bug, it would be great to close the loop on this by removing the special cases or converting them to errors.
@Centril Centril added C-future-incompatibility Category: Future-incompatibility lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Feb 28, 2020
@Centril
Copy link
Contributor

Centril commented Feb 28, 2020

It would be good to open a PR to change this to an error and do a crater run to see how things have progressed thus far.

@LeSeulArtichaut LeSeulArtichaut mentioned this issue Feb 28, 2020
Merged
@bors bors closed this as completed in 24757a8 Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-future-incompatibility Category: Future-incompatibility lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn trailing tokens in assert!() into hard errors LeSeulArtichaut/rust
2 participants
@Centril @adlerd