Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#73905 regressed several tests around associated type defaults #78049

Open
ishitatsuyuki opened this issue Oct 17, 2020 · 1 comment
Open

#73905 regressed several tests around associated type defaults #78049

ishitatsuyuki opened this issue Oct 17, 2020 · 1 comment
Labels
A-associated-items Area: Associated items (types, constants & functions) C-bug Category: This is a bug. F-associated_type_defaults `#![feature(associated_type_defaults)]` requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@ishitatsuyuki
Copy link
Contributor

ishitatsuyuki commented Oct 17, 2020 •
edited
Loading

It seems that several test regression got ignored in #73905:

While some of the other changes are acceptable, I think the changes listed above doesn't really get justified and seems to be a regression.

cc @matthewjasper
@ishitatsuyuki ishitatsuyuki mentioned this issue Oct 17, 2020
Closed
@matthewjasper
Copy link
Contributor

They do, this was moved to a different test file because the error prevents further compilation

@jonas-schievink jonas-schievink added A-associated-items Area: Associated items (types, constants & functions) C-bug Category: This is a bug. F-associated_type_defaults `#![feature(associated_type_defaults)]` requires-nightly This issue requires a nightly compiler in some way. labels Oct 17, 2020
@JohnTitor JohnTitor added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-associated-items Area: Associated items (types, constants & functions) C-bug Category: This is a bug. F-associated_type_defaults `#![feature(associated_type_defaults)]` requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonas-schievink @ishitatsuyuki @matthewjasper @JohnTitor