Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#99553 #99982

Closed
rust-highfive opened this issue Jul 31, 2022 · 2 comments · Fixed by #99984
Closed

miri no longer builds after rust-lang/rust#99553 #99982

rust-highfive opened this issue Jul 31, 2022 · 2 comments · Fixed by #99984
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #99553, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @ChrisDenton, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Jul 31, 2022
@RalfJung
Copy link
Member

Looks like the cfg(miri) codepath doesn't build:

error[E0133]: call to unsafe function is unsafe and requires unsafe function or block
    --> /home/r/.rustup/toolchains/miri/lib/rustlib/src/rust/library/std/src/sys/windows/compat.rs:254:21
     |
254  |                       Module::new($module).map(preload);
     |                       ^^^^^^^^^^^^^^^^^^^^ call to unsafe function
     |
    ::: /home/r/.rustup/toolchains/miri/lib/rustlib/src/rust/library/std/src/sys/windows/c.rs:1247:1
     |
1247 | / compat_fn_optional! {
1248 | |     pub static SYNCH_API: &CStr = ansi_str!("api-ms-win-core-synch-l1-2-0");
1249 | |
1250 | |     // >= Windows 8 / Server 2012
...    |
1258 | |     pub fn WakeByAddressSingle(Address: LPVOID) -> ();
1259 | | }
     | |_- in this macro invocation

@ChrisDenton
Copy link
Member

Yeah, sorry was just about to say. The cfg(miri) bits got out of sync with the code after edits. Fixing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants