Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf bot should remove S-waiting-on-perf when a bors try build fails #994

Closed
jyn514 opened this issue Sep 6, 2021 · 5 comments
Closed

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 6, 2021

Since the PR author will have to update the PR before perf can benchmark it; e.g. rust-lang/rust#88679 (comment)

@Mark-Simulacrum
Copy link
Member

Technically, the status is accurate -- the build remains queued even if the try build fails; we just wait for the first successful one. I definitely would prefer to avoid an additional comment left on the PR updating the state, so we'd want to work through the API (not rustbot).

@jyn514
Copy link
Member Author

jyn514 commented Sep 6, 2021

Technically, the status is accurate -- the build remains queued even if the try build fails; we just wait for the first successful one.

TIL! What happens if you run @rust-timer queue when a PR is already queued, does it just do nothing?

I definitely would prefer to avoid an additional comment left on the PR updating the state, so we'd want to work through the API (not rustbot).

👍

@Mark-Simulacrum
Copy link
Member

Yes, it's a noop if the PR is already "looking for try build".

@rylev
Copy link
Member

rylev commented Sep 15, 2021

Should this issue be closed then?

@Mark-Simulacrum
Copy link
Member

I think so. Going to go ahead and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants