-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tests/test_pattern_matching.py
from mypy.exclude config
#134
Comments
Perhaps I'm not fully understanding, can you clarify what you mean here? Or a PR would be great as well. Right now we do run |
Hm, sorry, I didn't consider pre 3.10 versions of python, would mypy flat out fail if you try to lint this file on 3.8 or 3.9? Because comment in |
Yeah because of differences between versions in what they support the GitHub CI config runs things based on what version. pattern matching, type checking, flake8, mypy are all configured like this. See https://github.com/rustedpy/result/blob/master/.github/workflows/ci.yml |
You're right. I'm not sure if there's a way to make it work between different versions though. For now I think updating the comment to mention this would be best. Anyway, I don't think this exclude is having any affect on users of this library, it only affects any developer working on this specific test file. I'm going to push up a commit to update the comment on |
Comment updated in cfda8ec. Trying to run mypy with a Python version that doesn't support pattern matching results in the following error:
|
I think comment in pyproject.toml was a bit misleading then 😅 maybe it should be changed to something like
|
Linked issue: python/mypy#10201
As of now that issue is closed and mypy supports pattern matching
The text was updated successfully, but these errors were encountered: