From a2359c6ad436f14c92e766670f9eb8112e772809 Mon Sep 17 00:00:00 2001 From: jairo-bc <68893868+jairo-bc@users.noreply.github.com> Date: Wed, 18 Nov 2020 15:34:50 +0200 Subject: [PATCH] STRF-8769 Moved zoomSize and productSize to the upper level, cause product.js is not availabe on the Quick View (#1884) --- CHANGELOG.md | 2 ++ templates/layout/base.html | 3 +++ templates/pages/product.html | 4 +--- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30bbd9f7f6..057324e55e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ - Cornerstone - Body text size above 14px is cut off on cart shipping dropdowns. [#1881](https://github.com/bigcommerce/cornerstone/pull/1881) - Move Tax Field under Grand Total on Cart when Tax inclusive. [#1903](https://github.com/bigcommerce/cornerstone/pull/1903) - Added styling config for the PayPal SPB on checkout page [#1866](https://github.com/bigcommerce/cornerstone/pull/1866) +- Moved zoomSize and productSize to the upper level, cause product.js is not availabe on the Quick View [#1884](https://github.com/bigcommerce/cornerstone/pull/1884) ## 4.12.1 (11-10-2020) - Write a Review modal cause TypeError. [#1899](https://github.com/bigcommerce/cornerstone/pull/1899) @@ -56,6 +57,7 @@ - Unified browsers list that we support. [#1836](https://github.com/bigcommerce/cornerstone/pull/1836) - Bump stencil utils and update hooks to account for refactor to drop Jquery in stencil utils [#1821](https://github.com/bigcommerce/cornerstone/pull/1821) + ## 4.11.0 (10-07-2020) - Add Info and Add Coupon forms on Cart Page tabbable when hidden. [#1820](https://github.com/bigcommerce/cornerstone/pull/1820) - Fixed outline styles for breadcrumbs on focus state. [#1824](https://github.com/bigcommerce/cornerstone/pull/1824) diff --git a/templates/layout/base.html b/templates/layout/base.html index d8fbbf7b79..f2c4993969 100644 --- a/templates/layout/base.html +++ b/templates/layout/base.html @@ -41,6 +41,9 @@ {{{head.scripts}}} + + {{~inject 'zoomSize' theme_settings.zoom_size}} + {{~inject 'productSize' theme_settings.product_size}} {{~inject 'showAdminBar' theme_settings.show-admin-bar}} {{~inject 'genericError' (lang 'common.generic_error')}} {{~inject 'maintenanceModeSettings' settings.maintenance}} diff --git a/templates/pages/product.html b/templates/pages/product.html index b8f4a2d0d2..5536b567e9 100644 --- a/templates/pages/product.html +++ b/templates/pages/product.html @@ -9,9 +9,7 @@ similar_by_views: limit: {{theme_settings.productpage_similar_by_views_count}} --- -{{inject "productId" product.id}} -{{inject "zoomSize" theme_settings.zoom_size}} -{{inject "productSize" theme_settings.product_size}} +{{inject 'productId' product.id}} {{#partial "page"}}