Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Implement eth_signTypedData for signing #3363

Closed
DmitryBespalov opened this issue Nov 16, 2023 · 4 comments
Closed

[iOS] Implement eth_signTypedData for signing #3363

DmitryBespalov opened this issue Nov 16, 2023 · 4 comments
Assignees
@DmitryBespalov
Labels
bug Doesn't work as expected Major Fix within 2 weeks

Comments

@DmitryBespalov
Copy link
Contributor

DmitryBespalov commented Nov 16, 2023 •
edited
Loading

Signing with eth_sign is deprecated in many wallets, we need to transition to the eth_signTypedData. This breaks the transaction execution and confirmation.
@DmitryBespalov DmitryBespalov self-assigned this Nov 16, 2023
@DmitryBespalov DmitryBespalov added infrastructure Technical tasks, not user-facing bug Doesn't work as expected Major Fix within 2 weeks and removed infrastructure Technical tasks, not user-facing labels Nov 16, 2023
@liliya-soroka
Copy link
Member

@DmitryBespalov , I can not enable push notifications for the MM key connected via WC v2
Image

@liliya-soroka
Copy link
Member

It's not possible to use MM mobile app. Could we check if it's on our side or MM ( MetaMask/metamask-mobile#7792)

@liliya-soroka
Copy link
Member

Tx signing and execution with MM mobile app work

@liliya-soroka
Copy link
Member

liliya-soroka commented Dec 20, 2023 •
edited
Loading

Using https://react-web3wallet.vercel.app/walletconnect , I have verified that signing method eth_signTypedData_4 works on mobile in the latest version
The task is verified

For execution, there is an issue with eth_sendTransaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryBespalov DmitryBespalov

Labels
bug Doesn't work as expected Major Fix within 2 weeks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DmitryBespalov @liliya-soroka