Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format issues #16

Open
jcutrell opened this issue Dec 11, 2018 · 0 comments
Open

Format issues #16

jcutrell opened this issue Dec 11, 2018 · 0 comments

Comments

@jcutrell
Copy link

It seems as though the format specification for Zipkin does not allow for null values (for example, for the parent ID).

Similarly, it seems that tags are intended to be defined as strings only.

The encoder should probably filter out key-value pairs from the serialization where values are null, and tag values should probably be converted to strings in a safe manner.

I came upon these issues when trying to send Zipkin spans to a Jaeger backend, and then found the data model for Zipkin here: https://zipkin.io/zipkin-api/#/default/post_spans

Perhaps I am misunderstanding something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant