Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra whitespace not removed for SSR snapshots #204

Closed
nolanlawson opened this issue Aug 8, 2023 · 1 comment · Fixed by #205
Closed

Extra whitespace not removed for SSR snapshots #204

nolanlawson opened this issue Aug 8, 2023 · 1 comment · Fixed by #205

Comments

@nolanlawson
Copy link
Contributor

nolanlawson commented Aug 8, 2023 •
edited
Loading

In #199 we removed extra whitespace (empty text nodes) from snapshots, but we only did this for client-side snapshots, not SSR snapshots.

This means that salesforce/lwc#3649 is still a breaking change for SSR snapshots.
@nolanlawson
Copy link
Contributor Author

I can't even think of a way to test this before salesforce/lwc#3649 is released; we can't manually insert empty text nodes because renderedCallback doesn't run...

@nolanlawson nolanlawson mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ssr): do not serialize ZWJ characters salesforce/lwc-test
1 participant
@nolanlawson