Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add creationDate to SecondFactor and ordering to second factor list in backend #34

Conversation

JamesAlias
Copy link
Contributor

@JamesAlias JamesAlias commented Aug 12, 2024

This adds a creationDate field to the SecondFactor entity. It's always nice to have this information and we can order by it.

The default ordering in the backend module list is account descending and creationDate descending.

SecondFactors without a creationDate will get a default value.
The default value will be shown as '-' in the backend module list.

Screenshot 2024-08-12 at 3 14 32 PM

@JamesAlias JamesAlias marked this pull request as ready for review August 12, 2024 13:36
@Benjamin-K
Copy link
Contributor

I'd prefer having

protected $defaultOrderings = [
    'account' => 'ASC',
    'creationDate' => 'DESC'
];

(at least that's what i'd expect).

But I really like having additional infos where easily possible 😍

@JamesAlias JamesAlias merged commit 3e3d492 into main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants