Fusion support #63
Open
Fusion support #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 31, 2024 13:54
codecrafter404
commented
Aug 2, 2024
| If you just want to apply simple modifications to the way the components are rendered, or which classes should be added to which HTML tags, override the responsible [presentation components](./Resources/Private/Fusion/Presentation/). This can be done like this: | ||
| ```fusion | ||
| prototype(Sandstorm.UserManagement:Component.LoginForm) < prototype(Neos.Fusion:Component) { | ||
| passwordResetUri > |
There was a problem hiding this comment.
we want to clear the renderer not the passwordResetUri
codecrafter404
commented
Aug 2, 2024
| fusionPathPatterns: | ||
| - resource://Neos.Fusion/Private/Fusion/Root.fusion | ||
| - resource://Neos.Fusion.Form/Private/Fusion/Root.fusion | ||
| - resource://Sandstorm.UserManagement/Private/Fusion/Root.fusion |
There was a problem hiding this comment.
Instead of Sandstorm.UserManagement -> Your.Vendor
codecrafter404
commented
Aug 2, 2024
| ## Fusion Support | ||
| - Full support for the default NodeTypes as follows: | ||
| - POC: migrate all fluid templates & overwrite them using the corresponding actions in the `Views.yaml` | ||
| - Ideally, most of the controller logic is obsolete in further releases and can be implemented in pure fusion or custom fusion components |
There was a problem hiding this comment.
controller logic -> render controller logic
codecrafter404
commented
Aug 2, 2024
| * *What happens if the user did not receive the registration email?* | ||
| Just tell the user to register again. In this case, previous unfinished registrations are discarded. | ||
| ## Fusion Support | ||
| - Full support for the default NodeTypes as follows: |
There was a problem hiding this comment.
default NodeTypes -> shipped/included NodeTypes
codecrafter404
commented
Aug 2, 2024
| ## What happens if the user did not receive the registration email? | ||
| Just tell the user to register again. In this case, previous unfinished registrations are discarded. | ||
|
|
||
| ## Why didn't you use X to implement fusion support? |
There was a problem hiding this comment.
Why are all render controller actions overwritten in the Views.yaml to implement fusion support?
codecrafter404
commented
Aug 2, 2024
There was a problem hiding this comment.
Find a better Naming convention, when the NodeTypes have been reworked
codecrafter404
commented
Aug 2, 2024
| } | ||
| } | ||
|
|
||
| renderer = Sandstorm.UserManagement:Component.ResetPassword.SetPassword { |
There was a problem hiding this comment.
use @apply.props=${props}
codecrafter404
commented
Aug 2, 2024
There was a problem hiding this comment.
Update Naming
rename Sites to Routes
rename Content.< Sitename > to Route.< Sitename >
and move all routes into one big /Resources/Private/Fusion/RoutePaths.fusion
codecrafter404
commented
Aug 2, 2024
| @@ -0,0 +1,9 @@ | |||
| resetPasswordSetPasswordSite = Sandstorm.UserManagement:SiteLayout { | |||
| title = 'Passwort-Änderung' | |||
codecrafter404
commented
Aug 2, 2024
| <body> | ||
| <h1>Hello World from Fusion!</h1> | ||
| <br/> | ||
| {props.flashmessages} |
There was a problem hiding this comment.
add support for flashmessages from the controllers
codecrafter404
commented
Aug 2, 2024
codecrafter404
commented
Aug 2, 2024
| @@ -0,0 +1,10 @@ | |||
| prototype(Sandstorm.UserManagement:Component.FieldContainer) < prototype(Neos.Fusion.Form:FieldContainer) { | |||
| errorRenderer = 'Sandstorm.UserManagement:Component.ErrorRenderer' | |||
| renderer = afx` | |||
There was a problem hiding this comment.
clear the renderer before renderer >
codecrafter404
commented
Aug 2, 2024
| @@ -0,0 +1,11 @@ | |||
| prototype(Sandstorm.UserManagement:Component.ErrorRenderer) < prototype(Neos.Fusion.Form:ErrorRenderer) { | |||
| renderer = afx` | |||
There was a problem hiding this comment.
clear the renderer before renderer >
codecrafter404
commented
Aug 2, 2024
| @@ -0,0 +1,11 @@ | |||
| prototype(Sandstorm.UserManagement:Component.ErrorRenderer) < prototype(Neos.Fusion.Form:ErrorRenderer) { | |||
There was a problem hiding this comment.
refactor to inherit from component
codecrafter404
commented
Aug 2, 2024
| <label> | ||
| {props.label} | ||
| {props.content} | ||
| <Neos.Fusion:Renderer @if.hasErrors={field.hasErrors()} type={props.errorRenderer} element.result={field.getResult()} /> |
There was a problem hiding this comment.
Use the ErrorHandler directly instead of instanciating it with Neos.Fusion:Renderer
codecrafter404
commented
Aug 2, 2024
There was a problem hiding this comment.
is obsolete is it doesn't add any new context
codecrafter404
commented
Aug 2, 2024
| prototype(Sandstorm.UserManagement:Component.Login) < prototype(Neos.Fusion:Component) { | ||
|
|
||
| account = '' | ||
| isAuthenticated = '' |
codecrafter404
commented
Aug 2, 2024
| account = ${props.account} | ||
| } | ||
| } | ||
| default { |
codecrafter404
commented
Aug 2, 2024
| } | ||
| } | ||
| default { | ||
| condition = ${true} |
codecrafter404
commented
Aug 2, 2024
| } | ||
| } | ||
| default { | ||
| condition = ${true} |
codecrafter404
commented
Aug 2, 2024
| renderer = Neos.Fusion:Case { | ||
| authenticated { | ||
| condition = ${props.isAuthenticated} | ||
| renderer = "You're already registered and logged in" // empty site |
codecrafter404
commented
Aug 2, 2024
| registrationFlow = '' | ||
|
|
||
| @private { | ||
| //translation = ${I18n.translate('registration.confirmationEmailSent', null, {'0': props.registrationFlow.email}, 'Main', 'Sandstorm.UserManagement', props.registrationFlow.email)} |
codecrafter404
commented
Aug 2, 2024
| renderer = afx` | ||
| <div class="callout success"> | ||
| <p> | ||
| Eine Email wurde an <strong>{resetPasswordFlow.email}</strong> versendet, |
codecrafter404
commented
Aug 2, 2024
codecrafter404
commented
Aug 2, 2024
| } | ||
| } | ||
| default { | ||
| condition = ${true} |
codecrafter404
commented
Aug 2, 2024
| } | ||
| default { | ||
| condition = ${true} | ||
| renderer = "General failure: invalid State" |
codecrafter404
commented
Aug 2, 2024
| } | ||
| default { | ||
| condition = ${true} | ||
| renderer = "Internal Failure: invalid state" |
codecrafter404
commented
Aug 2, 2024
| } | ||
| default { | ||
| condition = ${true} | ||
| renderer = "General failure: invalid State" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.