fix(ObjectValidator): don't run validation on arrays (#99)

sapphiredev · May 4, 2022 · c83b3d0 · c83b3d0
1 parent 45fbbf1
commit c83b3d0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/validators/ObjectValidator.ts b/src/validators/ObjectValidator.ts
@@ -80,6 +80,10 @@ export class ObjectValidator<T extends NonNullObject> extends BaseValidator<T> {
 			return Result.err(new ValidationError('s.object(T)', 'Expected the value to not be null', value));
 		}
 
+		if (Array.isArray(value)) {
+			return Result.err(new ValidationError('s.object(T)', 'Expected the value to not be an array', value));
+		}
+
 		return this.handleStrategy(value as NonNullObject);
 	}
 

diff --git a/tests/validators/object.test.ts b/tests/validators/object.test.ts
@@ -18,6 +18,10 @@ describe('ObjectValidator', () => {
 		expectError(() => predicate.parse(null), new ValidationError('s.object(T)', 'Expected the value to not be null', null));
 	});
 
+	test('GIVEN an array value THEN throws ValidationError', () => {
+		expectError(() => predicate.parse([]), new ValidationError('s.object(T)', 'Expected the value to not be an array', []));
+	});
+
 	test('GIVEN a valid object THEN returns processed object', () => {
 		expect(predicate.parse({ username: 'Sapphire', password: 'helloworld' })).toStrictEqual({ username: 'Sapphire', password: 'helloworld' });
 	});