Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: speed up object validation a LOT #101

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

vladfrangu
Copy link
Member

Note: this is a hella breaking change: Possibly undefined keys will now actually be missing from the object!

@favna favna changed the title chore: speed up object validation a LOT perf: speed up object validation a LOT May 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #101 (9521fbd) into main (741490f) will decrease coverage by 1.59%.
The diff coverage is 73.17%.

@@             Coverage Diff             @@
##              main     #101      +/-   ##
===========================================
- Coverage   100.00%   98.40%   -1.60%     
===========================================
  Files           50       50              
  Lines         1389     1446      +57     
  Branches       286      311      +25     
===========================================
+ Hits          1389     1423      +34     
- Misses           0       19      +19     
- Partials         0        4       +4     
Impacted Files Coverage Δ
src/validators/ObjectValidator.ts 85.16% <73.17%> (-14.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741490f...9521fbd. Read the comment docs.

@favna favna force-pushed the feat/speed-up-ignore-strategy branch from f55f5dd to 9521fbd Compare May 4, 2022 19:28
@favna favna merged commit 817278e into main May 4, 2022
@favna favna deleted the feat/speed-up-ignore-strategy branch May 4, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants