fix: make keys optional in object parsing #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imranbarbhuiya
requested review from
kyranet,
favna and
vladfrangu
as code owners
favna
requested changes
Jun 23, 2022
Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl>
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 53 53
Lines 3009 3013 +4
Branches 770 770
=======================================
+ Hits 2990 2994 +4
Misses 11 11
Partials 8 8
Continue to review full report at Codecov.
|
favna
approved these changes
Jun 26, 2022
vladfrangu
approved these changes
Jun 26, 2022
kyranet
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes keys optional instead of
| undefined.This is a hacky solution, I've tried various ways for 1 hr but can't find a better way of doing it, so if anyone has a better solution then lmk.
Playground