Looking for feedback on narrow backtrack causes approach #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I realized, as I woke up this morning, the solution is quite obvious. As only the downstream library can know the shape of their own requirements then this must be implemented there with resolvelib simply making a call to ask the library to narrow the causes if it can. Once I get a chance I will make an issue on Pip side, and once agreed this is a good idea I will edit this PR to simply call a narrow causes method on the downstream library. |
|
I've created an issue on Pip side (pypa/pip#12318), once I have feedback there I will make a clean PR here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an approach to #139 and fixes pypa/pip#12305 (comment)
However, as the test suite shows it's using methods that are not guaranteed to exist.
I am looking for feedback on how this could be implemented in a way that does not create brand new requirements on downstream libraries.