From 67a110998a1f198d5bc56a9da51a1a9bab193aa3 Mon Sep 17 00:00:00 2001
From: Natalie Weizenbaum <nweiz@google.com>
Date: Wed, 18 Oct 2023 14:53:42 -0700
Subject: [PATCH] Use a negative-safe cube root in LMS conversions (#2121)

See w3c/csswg-drafts#9477
---
 lib/src/value/color/space/lms.dart | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/lib/src/value/color/space/lms.dart b/lib/src/value/color/space/lms.dart
index aac56eb63..62596fa9b 100644
--- a/lib/src/value/color/space/lms.dart
+++ b/lib/src/value/color/space/lms.dart
@@ -37,9 +37,9 @@ class LmsColorSpace extends ColorSpace {
     switch (dest) {
       case ColorSpace.oklab:
         // Algorithm from https://drafts.csswg.org/css-color-4/#color-conversion-code
-        var longScaled = math.pow(long, 1 / 3);
-        var mediumScaled = math.pow(medium, 1 / 3);
-        var shortScaled = math.pow(short, 1 / 3);
+        var longScaled = _cubeRootPreservingSign(long);
+        var mediumScaled = _cubeRootPreservingSign(medium);
+        var shortScaled = _cubeRootPreservingSign(short);
         var lightness = lmsToOklab[0] * longScaled +
             lmsToOklab[1] * mediumScaled +
             lmsToOklab[2] * shortScaled;
@@ -62,9 +62,9 @@ class LmsColorSpace extends ColorSpace {
         // This is equivalent to converting to OKLab and then to OKLCH, but we
         // do it inline to avoid extra list allocations since we expect
         // conversions to and from OKLCH to be very common.
-        var longScaled = math.pow(long, 1 / 3);
-        var mediumScaled = math.pow(medium, 1 / 3);
-        var shortScaled = math.pow(short, 1 / 3);
+        var longScaled = _cubeRootPreservingSign(long);
+        var mediumScaled = _cubeRootPreservingSign(medium);
+        var shortScaled = _cubeRootPreservingSign(short);
         return labToLch(
             dest,
             lmsToOklab[0] * longScaled +
@@ -83,6 +83,11 @@ class LmsColorSpace extends ColorSpace {
     }
   }
 
+  /// Returns the cube root of the absolute value of [number] with the same sign
+  /// as [number].
+  double _cubeRootPreservingSign(double number) =>
+      math.pow(number.abs(), 1 / 3) * number.sign;
+
   @protected
   double toLinear(double channel) => channel;