Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url/metadata_url not passed to icecast output #2946

Closed
EricVanGorkom opened this issue Mar 7, 2023 · 1 comment
Closed

url/metadata_url not passed to icecast output #2946

EricVanGorkom opened this issue Mar 7, 2023 · 1 comment

Comments

@EricVanGorkom
Copy link

In addition to issue #2676 where the opposite thing is described, I want to pass the "url" metadata to an icecast output; in icecast itself it will be visible as "metadata_url".

It isn't processed by the output.icecast when I add "url" (or "metadata_url") to the metadata; however, I can pass the same metadata list (including "url") with an icy.update_metadata and it's processed correctly then by my icecast server, however, it'd be much more cleaner codewise to be able to just add it to the metadata list that is processed with the output.icecast - especially when you have multiple outputs for the same audiostream.

@toots
Copy link
Member

toots commented Mar 17, 2023

Hi @EricVanGorkom. To prevent potential leaks, exported metadata are filtered. See this setting: https://www.liquidsoap.info/doc-2.1.4/settings.html#exported-metadata

I'm adding "metadata_url" to the list, this will provide an end-to-end solution from input.harbor and output.icecast and prevent using the generic "url" label which may lead to inadvertent leak of internal request url.

@toots toots closed this as completed in 799c12d Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants