-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recording live broadcast breaks liquidsoap #3537
Comments
Logs :
Liquidsoap config:
|
Hi @netbladenl, Reproduction
Versions
|
Thanks so much for the detailed steps @vitoyucepi. I haven't been able to reproduce, however, either with my local dev env or using Thanks! |
OK, here's a docker-compose setup.
|
I can reproduce now but weirdly enough, on |
I'm having this same issue in 2.2.2. I just came on here to see if there was a solution, I may just roll back to 2.2.1 for now. |
I'll get to this as soon as possible. Thanks for y'all patience. |
I believe that the changes in this CI build might fix the problem: https://github.com/savonet/liquidsoap/actions/runs/6991394869 Any chance one of y'all could test them? |
Version 2.2.3+git@b2df6ca has the same problem. Log
|
I was able to test and confirm that the latest commit on the fix-has-ticked-2.2.x branch does fix the issue. Reproduction was tricky because it relied on two elements:
Partial frame fill can depend on timing such as when the harbor gets available. By changing the duration to |
Thanks for your work, unfortunately the problem still exists with the new version of liquidsoap
The autodj dont come back, after the streamer disconnects |
Sorry to hear. How did you test it? The rolling release guide hasn't completed yet.. |
Oh I thought that the patch was already released, my bad. I've asked Buster to use the newest rolling release of liquidsoap with the Azuracast rolling release. |
2.2.3+git@4181a8c works fine. |
The build of |
The problem has been resolved, thanks for all of your help! |
Describe the bug
I'm using the latest rolling release of Azuracast, and when the function to record live broadcasts is on liquidsoap stops working correctly. ID3 information is not being showed correctly. And when the streamer is disconnecting most of the time the autodj of liquidsoap dont play. and if it works you can hear the last seconds of the song being played before the streamer connects instead of directly a new song.
To Reproduce
In azuracast you have to go to edit station profile -> streamers/dj's
Turn on the option "Record Live Broadcasts" connect with butt or anything else that is able to set up a shoutcast/icecast stream and disconnect after a minute. Most likely the autodj doesnt play as it should. Turning this off solves the problem but live streamers wont be recorded.
Expected behavior
When streamer disconnects the autodj should be playing, and when the streamer is connected the ID3 information should be showed instead of the song before playing when the streamer connects
Version details
Install method
It's included within the docker distribution of Azuracast
Ticket at github of Azuracast ; AzuraCast/AzuraCast#6727
The text was updated successfully, but these errors were encountered: