Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input.harbor - SHOUTcast no: icy-name #380

Closed
desavil opened this issue Jan 9, 2017 · 7 comments
Closed

input.harbor - SHOUTcast no: icy-name #380

desavil opened this issue Jan 9, 2017 · 7 comments

Comments

@desavil
Copy link

desavil commented Jan 9, 2017

My configuration:

def on_harbor_connect (headers) =
list.iter (fun(h) -> log("header: #{fst(h)}: #{snd(h)}"), headers)
end
live = input.harbor("/",port=8000,password="hackme",icy=true,on_connect=on_harbor_connect)

Logs:

2017/01/10 00:40:02 [lang:3] header: icy-genre: R&B and Urban
2017/01/10 00:40:02 [lang:3] header: icy-url: http://www.test.com
2017/01/10 00:40:02 [lang:3] header: icy-irc: N/A
2017/01/10 00:40:02 [lang:3] header: icy-icq: 0
2017/01/10 00:40:02 [lang:3] header: icy-aim: N/A
2017/01/10 00:40:02 [lang:3] header: icy-pub: 1
2017/01/10 00:40:02 [lang:3] header: icy-br: 128
2017/01/10 00:40:02 [lang:3] header: content-type: audio/mpeg

There is no "Name" (icy-name) - https://i.snag.gy/ClUVNA.jpg

@toots
Copy link
Member

toots commented Jan 10, 2017

Have you checked what is effectively passed by the client? set("log.level",4) should help..

@desavil
Copy link
Author

desavil commented Jan 10, 2017

2017/01/10 10:51:44 [harbor:4] New client on port 8001: x.x.x.x
2017/01/10 10:51:44 [harbor:4] Header: icy-genre, value: R&B and Urban.
2017/01/10 10:51:44 [harbor:4] Header: icy-url, value: http://www.test.com.
2017/01/10 10:51:44 [harbor:4] Header: icy-irc, value: N/A.
2017/01/10 10:51:44 [harbor:4] Header: icy-icq, value: 0.
2017/01/10 10:51:44 [harbor:4] Header: icy-aim, value: N/A.
2017/01/10 10:51:44 [harbor:4] Header: icy-pub, value: 1.
2017/01/10 10:51:44 [harbor:4] Header: icy-br, value: 128.
2017/01/10 10:51:44 [harbor:4] Header: content-type, value: audio/mpeg.
2017/01/10 10:51:44 [harbor:4] ICY request on /.
2017/01/10 10:51:44 [harbor:4] Adding source on mountpoint "/" with type "audio/mpeg".
2017/01/10 10:51:44 [decoder:4] Trying method "WAV" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:4] Trying method "AIFF" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:4] Trying method "PCM/BASIC" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:4] Trying method "RAW AUDIO" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:4] Trying method "FLAC" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:4] Trying method "AAC" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:4] Trying method "OGG" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:4] Trying method "MAD" for "audio/mpeg"...
2017/01/10 10:51:44 [decoder:3] Method "MAD" accepted "audio/mpeg".
2017/01/10 10:51:44 [lang:3] header: icy-genre: R&B and Urban
2017/01/10 10:51:44 [lang:3] header: icy-url: http://www.test.com
2017/01/10 10:51:44 [lang:3] header: icy-irc: N/A
2017/01/10 10:51:44 [lang:3] header: icy-icq: 0
2017/01/10 10:51:44 [lang:3] header: icy-aim: N/A
2017/01/10 10:51:44 [lang:3] header: icy-pub: 1
2017/01/10 10:51:44 [lang:3] header: icy-br: 128
2017/01/10 10:51:44 [lang:3] header: content-type: audio/mpeg

@toots
Copy link
Member

toots commented Jan 10, 2017

So, no icy-name is passed down to input.harbor, which explains why you do not see it..

@desavil
Copy link
Author

desavil commented Jan 10, 2017

Please look this (yellow) - https://i.snag.gy/3MPGHV.jpg
Tcpdump log from server with liquidsoap.

It seems as if liquidsoap ignore the first icy line.

@toots
Copy link
Member

toots commented Jan 10, 2017

Interesting, thanks. Could you attach a ASCII dump of it?

@desavil
Copy link
Author

desavil commented Jan 10, 2017

I sent you an e-mail.

@toots
Copy link
Member

toots commented Jan 11, 2017

Well, that was another stupid one.. Thanks for the report, fixed in 04c28e0

@toots toots closed this as completed Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants