From ef91bfea4bb42f9dd82a2871fd07cc9a6efe94d4 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Wed, 11 Oct 2023 11:24:11 -0700 Subject: [PATCH] Update docs relating to EM_JS and side modules This was fixed in #19705. --- ChangeLog.md | 2 ++ site/source/docs/compiling/Dynamic-Linking.rst | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ChangeLog.md b/ChangeLog.md index 0a3fad26f486..288900b50d3f 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -112,6 +112,7 @@ See docs/process.md for more on how version tagging works. with the new `__i53abi` decorator. When this is set to true, i64 values are automatically converted to JS numbers (i53) at the JS boundary. Parameters outside of the i53 will show up as NaN in the JS code (#19711) +- EM_JS functions are now supported in side modules (#19705) 3.1.42 - 06/22/23 ----------------- @@ -357,6 +358,7 @@ See docs/process.md for more on how version tagging works. occupy linear memory at all. The default for `DEFAULT_PTHREAD_STACK_SIZE` was also reduced from 2MB to 64KB to match. - Improved error messages for writing custom JS libraries. (#18266) +- EM_ASM code is now supported in side modules (#18228) 3.1.26 - 11/17/22 ----------------- diff --git a/site/source/docs/compiling/Dynamic-Linking.rst b/site/source/docs/compiling/Dynamic-Linking.rst index afafea0b4e8a..331c96abd3ec 100644 --- a/site/source/docs/compiling/Dynamic-Linking.rst +++ b/site/source/docs/compiling/Dynamic-Linking.rst @@ -211,9 +211,8 @@ Limitations ``file_packager.py``) to make Emscripten compile them on startup `[doc] `__ `[discuss] `__. -- ``EM_ASM`` code defined within side modules depends on ``eval`` support are - is therefore incompatible with ``-sDYNAMIC_EXECUTION=0``. -- ``EM_JS`` functions defined in side modules are not yet supported. +- ``EM_ASM`` and ``EM_JS`` code defined within side modules depends on ``eval`` + support are is therefore incompatible with ``-sDYNAMIC_EXECUTION=0``. Pthreads support