Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalikejdbc-async and r2dbc #368

Open
jtjeferreira opened this issue Dec 26, 2022 · 3 comments
Open

scalikejdbc-async and r2dbc #368

jtjeferreira opened this issue Dec 26, 2022 · 3 comments

Comments

@jtjeferreira
Copy link
Contributor

Do you have any plans to integrate with r2dbc. The GA version was recently released...

@seratch
Copy link
Member

seratch commented Dec 27, 2022

I tried R2DBC a few years ago. My impression back then is that the library is not so Scala-friendly. If it's feasible to configure R2DBC in this project's way, plus it's easy enough to have a bridge between their types and Scala futures, adding something to this project would be great.

With that being said, I no longer write Scala code a lot (sorry about that!). So, I'm still happy to be a reviewer for PRs, but I won't work on the feature addition.

@jtjeferreira
Copy link
Contributor Author

I never used r2dbc before, but looking at the APIs they use reactivestreams Publisher. I guess those can be transformed to Scala futures using akka or even reactor?

Or maybe jasync-sql will adopt r2dbc and scalikejdbc-async just has to use that (with the downside of having to convert twice r2dbc <-> jasync-sql <-> scalikejdbc-async )?

I will explore the first idea a bit to see how far I can get...

@oshai
Copy link

oshai commented Jan 18, 2023

I never used r2dbc before, but looking at the APIs they use reactivestreams Publisher. I guess those can be transformed to Scala futures using akka or even reactor?

Or maybe jasync-sql will adopt r2dbc and scalikejdbc-async just has to use that (with the downside of having to convert twice r2dbc <-> jasync-sql <-> scalikejdbc-async )?

I will explore the first idea a bit to see how far I can get...

jasync-sql is already r2dbc compliant (for mysql), but in the other way around (it is a driver with r2dbc wrapper).
so IIUC with scalike-r2dbc integration you could have many db's which one of them is mysql via jasync-r2dbc module in jasync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants