You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a maintainer/user, I want the acquisition function builders to be lightweight: easy to compose, construct and generally manipulate, so that code is easier to read, conceptualise and extend.
To this end, I propose changing the acquisition function builders to be functions not classes. For example:
If it's not clear to users what is and isn't an acquisition function builder by its signature, we could either take care to say what is an AcquisitionFunctionBuilder in the docstring for each one, or do the following workaround:
which returns a builder, rather than is one. It appears this would show up clearly in the docs. It may also be clearer to put everything on the same footing and have them all return builders:
This is no longer plausible as AcquisitionFunctionBuilder now also includes the logic for updating functions without retracing. (In fact, it's likely that a better solution would have been to remove AcquisitionFunctionBuilders altogether and just use an AcquisitionFunction class that handles updates itself, but at this point this looks like far too much work: #650.)
As a maintainer/user, I want the acquisition function builders to be lightweight: easy to compose, construct and generally manipulate, so that code is easier to read, conceptualise and extend.
To this end, I propose changing the acquisition function builders to be functions not classes. For example:
If it's not clear to users what is and isn't an acquisition function builder by its signature, we could either take care to say what is an
AcquisitionFunctionBuilder
in the docstring for each one, or do the following workaround:This would obviously not be needed for e.g.
which returns a builder, rather than is one. It appears this would show up clearly in the docs. It may also be clearer to put everything on the same footing and have them all return builders:
The text was updated successfully, but these errors were encountered: