Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github release action makes a tarbomb #27

Open
winny- opened this issue Feb 14, 2023 · 1 comment
Open

github release action makes a tarbomb #27

winny- opened this issue Feb 14, 2023 · 1 comment

Comments

@winny-
Copy link
Collaborator

winny- commented Feb 14, 2023

pretty insane that archive hygiene is still an educational problem in 2023.

$ tar -tzf ~/Downloads/jhmod-v0.0.1-pre-linux-386.tar.gz 
LICENSE
README.md
examples/
examples/pathlist.txt
jhmod
scripts/
scripts/get-core

winny- added a commit that referenced this issue Feb 14, 2023
winny- added a commit that referenced this issue Feb 14, 2023
@winny-
Copy link
Collaborator Author

winny- commented Feb 14, 2023

Well... kinda fixed it

winston@icarus /tmp $ tar -tzf ~/Downloads/jhmod-v0.0.1-pre3-linux-386.tar.gz 
build-artifacts-1676379384/LICENSE
build-artifacts-1676379384/README.md
build-artifacts-1676379384/examples/
build-artifacts-1676379384/examples/pathlist.txt
build-artifacts-1676379384/jhmod
build-artifacts-1676379384/scripts/
build-artifacts-1676379384/scripts/get-core
winston@icarus /tmp $ tar -tzf ~/Downloads/jhmod-v0.0.1-pre3-linux-amd64.tar.gz 
build-artifacts-1676379381/LICENSE
build-artifacts-1676379381/README.md
build-artifacts-1676379381/examples/
build-artifacts-1676379381/examples/pathlist.txt
build-artifacts-1676379381/jhmod
build-artifacts-1676379381/scripts/
build-artifacts-1676379381/scripts/get-core

Need to rework the script to instead use a more human readable folder name. But it is no longer a tarbomb. So half way there! Either case going to release v0.0.1 because this is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant