Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for embedded YouTube videos #121

Open
rsubr opened this issue Feb 24, 2024 · 1 comment · May be fixed by #133
Open

support for embedded YouTube videos #121

rsubr opened this issue Feb 24, 2024 · 1 comment · May be fixed by #133
Labels
enhancement New feature or request To Do on the to do list

Comments

@rsubr
Copy link

rsubr commented Feb 24, 2024

Thanks for this wonderful project. I am effortlessly publishing my notes online in docker using Gitea webhooks.

Obsidian supports embedding YouTube videos using the same images markdown syntax. Perlite does not support this feature and incorrectly renders YouTube videos as images - none of the YouTube videos are loading. Obsidian Publish renders YouTube links correctly.

Obsidian YouTube Markdown

![Making a Minecraft Obsidian Block in Real Life Using Astro Tech Resin](https://www.youtube.com/watch?v=NnTvZWp5Q7o)

Incorrect Perlite Rendering as IMG

Perlite does not support this and YouTube videos are rendered using an img tag like this:

<img src="https://www.youtube.com/watch?v=NnTvZWp5Q7o"
    alt="Making a Minecraft Obsidian Block in Real Life Using Astro Tech Resin"
    class="external-link perlite-external-link" target="_blank" rel="noopener noreferrer">

Obsidian Publish Rendering as IFRAME

The html used by Obsidian Publish for embedding YouTube is this:

<iframe class="external-embed mod-receives-events"
    sandbox="allow-forms allow-presentation allow-same-origin allow-scripts allow-modals allow-popups"
    allow="fullscreen"
    frameborder="0"
    src="https://www.youtube.com/embed/NnTvZWp5Q7o">
</iframe>

Please note that in Obsidian also recognizes the below forms and the iframe is generated correctly:

![](https://www.youtube.com/watch?v=NnTvZWp5Q7o)

![](https://www.youtu.be/NnTvZWp5Q7o)

![](https://youtu.be/NnTvZWp5Q7o)

Can we please get support for Obsidian YouTube links?

Thanks again for the great project!

@rsubr rsubr added the enhancement New feature or request label Feb 24, 2024
@secure-77
Copy link
Owner

Thanks for the feedback and this well prepared issue! ❤️

This should be doable 👍 I will try to implement it for the next release!

@secure-77 secure-77 added the To Do on the to do list label Mar 6, 2024
@rsubr rsubr linked a pull request Aug 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To Do on the to do list
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants