Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.1.0 #57

Merged
merged 8 commits into from
May 16, 2024
Merged

Rc 1.1.0 #57

merged 8 commits into from
May 16, 2024

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented May 13, 2024

pyrtcm Pull Request Template

Description

ENHANCEMENTS:

  1. PRN, CELLPRN and CELLSIG attributes added to satellite (NSAT) and cell (NCELL) groups within parsed RTCM3 MSM payloads via SPARTNMessage._getsatcellmaps() function, replacing previous sat2prn() and cell2prn() helper functionality e.g. PRN_05=006, CELLPRN_01=001, CELLSIG_01=1C
  2. labelmsm keyword argument signifies either RINEX (1) or Frequency Band (2) signal format for CELLSIG attribute.

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Streaming tests updated
  • Static tests updated

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my RTCM documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the enhancement New feature or request label May 13, 2024
@semuadmin semuadmin self-assigned this May 13, 2024
@semuadmin semuadmin added this to the RC 1.1.0 milestone May 13, 2024
@semuadmin semuadmin marked this pull request as draft May 13, 2024 06:43
@semuadmin semuadmin marked this pull request as ready for review May 16, 2024 08:36
@semuadmin semuadmin requested a review from a team May 16, 2024 08:36
@semuadmin semuadmin merged commit 8568047 into main May 16, 2024
5 checks passed
@semuadmin semuadmin deleted the RC-1.1.0 branch May 16, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants