Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass empty client instead of http.DefaultClient #101

Merged
merged 1 commit into from
Sep 29, 2020
Merged

fix: Pass empty client instead of http.DefaultClient #101

merged 1 commit into from
Sep 29, 2020

Conversation

mateorider
Copy link
Contributor

Fixes

[Closes #98]

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 25, 2020
eshanholtz
eshanholtz approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshanholtz eshanholtz merged commit 47a8517 into sendgrid:main Sep 29, 2020
@mateorider mateorider deleted the update-default-client branch September 29, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that a custom HTTP client should be used when deploying to AWS
3 participants
@mateorider @eshanholtz @thinkingserious