Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update CONTRIBUTING.md with environment variables section #62

Merged
merged 1 commit into from
Jan 17, 2020
Merged

docs: update CONTRIBUTING.md with environment variables section #62

merged 1 commit into from
Jan 17, 2020

Conversation

thepriefy
Copy link
Contributor

@thepriefy thepriefy commented Oct 31, 2017 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • add Environment Variables section

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thepriefy
update CONTRIBUTING.md
14a9ab8 
add Environment Variables section
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@mrmuskrat
Copy link
Contributor

Looks good to me

@thinkingserious thinkingserious added the difficulty: easy fix is easy in difficulty label Nov 9, 2017
@thinkingserious
Copy link
Contributor

Thanks for the help @JessedB!

@thinkingserious thinkingserious added the type: docs update documentation change not affecting the code label Mar 6, 2018
@thinkingserious thinkingserious changed the title update CONTRIBUTING.md docs: update CONTRIBUTING.md Jan 17, 2020
@thinkingserious thinkingserious merged commit 84fac13 into sendgrid:master Jan 17, 2020
@thinkingserious
Copy link
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title docs: update CONTRIBUTING.md docs: update CONTRIBUTING.md with environment variables section Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesse-deboer jesse-deboer jesse-deboer approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thepriefy @mrmuskrat @thinkingserious @jesse-deboer @mbernier