Allow for setting a custom HTTP client #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given the hiccups with the CLA and need for a fix, I went ahead and created this pull request. I would appreciate a quick review to ensure this will do what you need. For reference, this closes: |
|
Looks good to me. Thanks for porting! |
|
|
||
| func TestCustomHTTPClient(t *testing.T) { | ||
| fakeServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| time.Sleep(time.Second * 2) |
There was a problem hiding this comment.
These timeouts can be shorter - try 10ms & 20ms.
|
LGTM |
| BaseURL: baseURL, | ||
| } | ||
| customClient := &Client{&http.Client{Timeout: time.Second * 1}} | ||
| _, e := customClient.API(request) |
There was a problem hiding this comment.
s/e/err/
if _, err := customClient.API(request); err == nil {
t.Error("got nil, want non-nil err")
}
|
Thanks for the feedback! I'll make the suggested changes here and get this deployed and update the dependency in sendgrid-go. |
thinkingserious
added a commit
that referenced
this pull request
Jul 28, 2016
|
Thank you so much for your support and help on this! Please send us your mailing address and T-shirt size (dx@sendgrid.com) so we can give you a small token of our appreciation. |
|
woohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.