Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in Es modules example #500

Closed
cellulosa opened this issue Sep 10, 2021 · 2 comments
Closed

Typos in Es modules example #500

cellulosa opened this issue Sep 10, 2021 · 2 comments

Comments

@cellulosa
Copy link
Contributor

cellulosa commented Sep 10, 2021 •
edited
Loading

It should be getModule()).down(downParams) in

umzug/examples/2.es-modules/umzug.mjs

Line 24 in ad50a47

down: async downParams => (await getModule()).up(downParams),

Also import.meta.url.replace('file:///', '/') in

umzug/examples/2.es-modules/umzug.mjs

Line 16 in ad50a47

glob: ['migrations/*.{js,cjs,mjs}', { cwd: path.dirname(import.meta.url.replace('file:///', '')) }],

@cellulosa cellulosa changed the title Typo in Es modules example Typos in Es modules example Sep 10, 2021
@mmkal
Copy link
Contributor

mmkal commented Sep 20, 2021

Thank you! Would you like to open a PR to fix?

@cellulosa
Copy link
Contributor Author

cellulosa commented Sep 22, 2021 •
edited
Loading

Thank you! Would you like to open a PR to fix?

done ;) Pull request #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cellulosa @mmkal