Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be feasible to reload certificates during runtime? #4

Closed
shepmaster opened this issue Mar 26, 2017 · 4 comments
Closed

Would it be feasible to reload certificates during runtime? #4

shepmaster opened this issue Mar 26, 2017 · 4 comments

Comments

@shepmaster
Copy link

shepmaster commented Mar 26, 2017

From what I've seen, the certificate file is loaded a single time at construction. Let's Encrypt certificates expire every 90 days. I tend to not restart my server that frequently, which means that the certificate will be the forcing function to restart.

Do you think that this is a desirable feature to reside in this library? If so, I'd be happy to take a first crack at it, so any guidance would be appreciated.

@sfackler
Copy link
Owner

See sfackler/rust-native-tls#27 - I would prefer a more traditional setup as well, but it's a question of figuring out how to make that happen for macOS and Windows.

@shepmaster
Copy link
Author

I might have confused you with my similarly-titled simultaneous issues; I think you wanted that in #3 ?

@sfackler
Copy link
Owner

Derp, yes!

For this issue in particular, I believe this would best be done in a separate crate that implements an SslServer which allows an inner SslServer to be swapped out via some handle at runtime. You can then have some code that periodically looks for a new certificate/key, builds an SslServer out of them and installs it.

@shepmaster
Copy link
Author

Yep, I figured that would be the suggestion, just figured I'd ask before going off and making it elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants