Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping openssl to 3.x is breaking builds and should maybe be a minor version bump #1549

Closed
toidiu opened this issue Nov 1, 2021 · 4 comments

Comments

@toidiu
Copy link

toidiu commented Nov 1, 2021

This commit bumps the vendor-ed version of openssl: e5999cc

However the version of openssl-sys was only bumped from 0.9.68 to 0.9.69 (a patch version update). I am unfamiliar with the project but maybe this should be a minor version bump rather than a patch update?

@sfackler
Copy link
Owner

sfackler commented Nov 1, 2021

The OpenSSL version will generally track the newest OpenSSL release, and changes to the version are not considered breaking changes.

https://docs.rs/openssl/0.10.38/openssl/#vendored

@toidiu
Copy link
Author

toidiu commented Nov 1, 2021

Ack, thanks for the response!

@toidiu toidiu closed this as completed Nov 1, 2021
@danni-m
Copy link

danni-m commented Nov 4, 2021

@sfackler The upgrade probably caused an issue with kube-rs on macos:
kube-rs/kube#691

@Stargateur
Copy link

BTW, 0.x.y, x is major and y is minor, there is no patch for <1 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants