Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile cut off on map page #128

Closed
BeeSeeWhy opened this issue May 23, 2024 · 3 comments · Fixed by #134
Closed

Mobile cut off on map page #128

BeeSeeWhy opened this issue May 23, 2024 · 3 comments · Fixed by #134
Assignees
Labels
bug Something isn't working

Comments

@BeeSeeWhy
Copy link
Collaborator

BeeSeeWhy commented May 23, 2024

On mobile:
-the initial instructions are cut off by web browser UI
-the map cards are cut off by web browser UI
-francis suggestion needs research: @sparing_software

Reported by @juliagoolia and other members

@francisli
Copy link

I posted this in Slack but I'll also paste it here in case it is helpful, this library helped me solve issues with positioning in mobile browsers:

https://www.npmjs.com/package/@sparing-software/100vh

The issue is that as the browser toolbars shrink/expand, css positioning can get out of whack...

@nickvisut nickvisut self-assigned this May 28, 2024
@nickvisut
Copy link
Collaborator

We can upgrade to the latest tailwind to use their official h-dvh directly (instead of h-screen, which is equivalent to height: 100vh, which simply doesn't work on e.g. mobile Safari).

However, even the latest Tailwind doesn't currently include a fallback to non-supported browsers, so we'd still need to roll our own fallback to vh regardless.

@nickvisut nickvisut mentioned this issue May 28, 2024
@nickvisut nickvisut added the bug Something isn't working label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants