Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong frame rate in output MPD with TS input #662

Closed
joeyparrish opened this issue Oct 12, 2019 · 2 comments
Closed

Wrong frame rate in output MPD with TS input #662

joeyparrish opened this issue Oct 12, 2019 · 2 comments
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue

Comments

@joeyparrish
Copy link
Member

System info

Operating System: gLinux / Debian testing
Shaka Packager Version: v2.3.0-5bf8ad5-release

Issue and steps to reproduce the problem

Packager Command:

wget https://storage.googleapis.com/shaka-streamer-assets/test-assets/Sintel.2010.720p.Small.mkv

# Transcode into a TS container.
ffmpeg \
  -y -loglevel error \
  -to 0:01 -i Sintel.2010.720p.Small.mkv \
  -an -c:v h264 -b:v 3M intermediate.ts

# Package that TS into MP4 in DASH.
packager \
  'in=intermediate.ts,stream=video,output=from_ts.mp4' \
  --mpd_output from_ts.mpd

# Transcode into an MP4 container.
ffmpeg \
  -y \
  -to 0:01 -i Sintel.2010.720p.Small.mkv \
  -an -c:v h264 -b:v 3M intermediate.mp4

# Package that MP4 into MP4 in DASH, in a different manifest file from before.
packager \
  'in=intermediate.mp4,stream=video,output=from_mp4.mp4' \
  --mpd_output from_mp4.mpd

What is the expected result?

I would expect the frame rate in the MPD to be correct in both cases.

What happens instead?

The frame rate of the input file is 24 fps according to ffprobe. The frame rate of both intermediate.ts and intermediate.mp4 are 24 fps according to ffprobe. After packaging, the frame rate of both from_mp4.mp4 and from_ts.mp4 are 24 fps.

In from_mp4.mpd, the frameRate attribute is 12288/512, or 24 fps.

In from_ts.mpd, the frameRate attribute is 90000/7500, or 12 fps.

Something seems to go wrong when the intermediate file is TS instead of MP4.

If you run the same test with a different source file (https://storage.googleapis.com/shaka-streamer-assets/sample-inputs/Sintel.2010.720p.mkv), Packager does the right thing. It's not clear why that would be.

@kqyang
Copy link
Contributor

kqyang commented Oct 14, 2019

@joeyparrish Thanks for the report. Will take a look.

@joeyparrish joeyparrish changed the title Wrong frame rate in output MPD Wrong frame rate in output MPD with TS input Apr 15, 2020
@kqyang
Copy link
Contributor

kqyang commented Apr 16, 2020

I assume this is caused by the same problem as #751. Mark it as a duplicate.

@kqyang kqyang closed this as completed Apr 16, 2020
@kqyang kqyang added status: duplicate A duplicate of another issue; should be closed after linking to the original issue and removed needs triage labels Apr 16, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 15, 2020
@shaka-project shaka-project locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue
Projects
None yet
Development

No branches or pull requests

3 participants