Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/refactor: ts migration for poi/limited #41

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { POILimited } from './limited.jsx';
import { POILimited } from './limited';

export default POILimited;
2 changes: 1 addition & 1 deletion packages/account/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@
"@deriv/*": ["../*/src"]
}
},
"include": ["src","globals.d.ts"]
"include": ["src", "globals.d.ts"]
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ type TMobileDialog = {
header_classname?: string;
has_full_height?: boolean;
footer?: React.ReactNode;
has_close_icon: boolean;
};

const MobileDialog = (props: React.PropsWithChildren<TMobileDialog>) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ type TSelectNative = {
hide_selected_value?: boolean;
value: string | number;
list_items: Array<TListItem> | { [key: string]: Array<TListItem> };
hide_top_placeholder: boolean;
} & Omit<TSelectNativeOptions, 'list_items'> &
Omit<React.SelectHTMLAttributes<HTMLSelectElement>, 'value'>; // Default type of value in HTMLSelectElement is only string but here string | number is required

Expand Down
2 changes: 1 addition & 1 deletion packages/components/stories/icon/icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -885,4 +885,4 @@ export const icons =
'IcWalletZingpayDark',
'IcWalletZingpayLight',
],
};
}
1 change: 1 addition & 0 deletions packages/core/global.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ declare global {
};
LC_API: {
on_chat_ended: VoidFunction;
open_chat_window: VoidFunction;
};
}
}
Expand Down