Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

kiki_dev - UniV3SwapInput() Missing slippage protection #120

Closed
sherlock-admin opened this issue May 23, 2023 · 0 comments
Closed

kiki_dev - UniV3SwapInput() Missing slippage protection #120

sherlock-admin opened this issue May 23, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 23, 2023

kiki_dev

high

UniV3SwapInput() Missing slippage protection

Summary

There is no slippage being enforced which allows any amount to be returned. The gives attackers the chance to steal funds from this transaction.

Vulnerability Detail

Because amountOutMinimum is hard coded to zero any value can be returned allowing these transactions to be sandwich attacked and allow an attack to steal most all funds.

Impact

Loss of funds

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/USSD.sol#L237

Tool used

Manual Review

Recommendation

Have a dynamic amountOutMinimum value that lets the protocol or user(ideal) choose the acceptable amount out.

Duplicate of #673

@github-actions github-actions bot closed this as completed Jun 5, 2023
@github-actions github-actions bot added High A valid High severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 5, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant