Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

Fanz - function UniV3SwapInput not set deadline #5

Closed
sherlock-admin opened this issue May 23, 2023 · 0 comments
Closed

Fanz - function UniV3SwapInput not set deadline #5

sherlock-admin opened this issue May 23, 2023 · 0 comments
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 23, 2023 •
edited by github-actions bot
Loading

Fanz

high

function UniV3SwapInput not set deadline

Summary

function UniV3SwapInput not set deadline

Vulnerability Detail

Tx could be stuck in mempool depend on priority if not set deadline could be got unexpected execute.

Impact

protocol could be losing funds

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/USSD.sol#L235

Tool used

Manual Review

Recommendation

Set deadline

Duplicate of #673
@github-actions github-actions bot closed this as completed Jun 5, 2023
@github-actions github-actions bot added High A valid High severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 5, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sherlock-admin