n33k - Commented deadline parameter makes UniV3SwapInput unusable

[sherlock-admin]

n33k

medium

Commented deadline parameter makes UniV3SwapInput unusable

Summary

The deadline parameter is commented out so that the swap in UniV3SwapInput will fail.

Vulnerability Detail

The deadline is commented out but is required by exactInput.

    function UniV3SwapInput(
        bytes memory _path,
        uint256 _sellAmount
    ) public override onlyBalancer {
        IV3SwapRouter.ExactInputParams memory params = IV3SwapRouter
            .ExactInputParams({
                path: _path,
                recipient: address(this),
                //deadline: block.timestamp,
                amountIn: _sellAmount,
                amountOutMinimum: 0
            });
        uniRouter.exactInput(params);
    }

Impact

UniV3SwapInput unusable.

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/main/ussd-contracts/contracts/USSD.sol#L235

Tool used

Manual Review

Recommendation

Remove the comment.

Duplicate of #673