Skip to content
This repository has been archived by the owner on Nov 26, 2023. It is now read-only.

innertia - Sandwich attack could result in substantial losses #920

Closed
sherlock-admin opened this issue May 24, 2023 · 0 comments
Closed
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue

Comments

@sherlock-admin
Copy link
Contributor

sherlock-admin commented May 24, 2023

innertia

high

Sandwich attack could result in substantial losses

Summary

The minimum amount of tokens to be received is not set when swapping tokens.
Therefore, an attacker can launch a sandwich attack on a swap transaction to unfairly reduce the amount of tokens received by the project.
This is a substantial loss of funds.

Vulnerability Detail

In the UniV3SwapInput(bytes memory _path, uint256 _sellAmount) function, amountOutMinimum is hard-coded to 0. Therefore, the token received could be zero.
A sandwich attack could result in a significant loss of project assets.

Impact

Substantial loss of property value

Code Snippet

https://github.com/sherlock-audit/2023-05-USSD/blob/6d7a9fdfb1f1ed838632c25b6e1b01748d0bafda/ussd-contracts/contracts/USSD.sol#L237

Tool used

Manual Review

Recommendation

Set the appropriate value for amountOutMinimum, depending on the situation.

Duplicate of #673

@github-actions github-actions bot closed this as completed Jun 5, 2023
@github-actions github-actions bot added High A valid High severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Jun 5, 2023
@sherlock-admin sherlock-admin added the Reward A payout will be made for this issue label Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label High A valid High severity issue Reward A payout will be made for this issue
Projects
None yet
Development

No branches or pull requests

1 participant