Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faraday::TimeoutError not mapped into any ClickHouse error #44

Open
madejejej opened this issue Sep 8, 2023 · 0 comments
Open

Faraday::TimeoutError not mapped into any ClickHouse error #44

madejejej opened this issue Sep 8, 2023 · 0 comments

Comments

@madejejej
Copy link
Contributor

madejejej commented Sep 8, 2023

Currently, the library can raise a Faraday::TimeoutError.

In the RaiseError middleware we catch Faraday::ConnectionFailed and remap it to ClickHouse::NetworkException:

rescue Faraday::ConnectionFailed => e

However, TimeoutError isn't a descendant of ConnectionFailed:

https://github.com/lostisland/faraday/blob/ea30bd0b543882f1cf26e75ac4e46e0705fa7e68/lib/faraday/error.rb#L132

I suggest we also catch Faraday::TimeoutError (and perhaps a few more Faraday errors?) and remap it to ClickHouse errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant