Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with 'Show PB for Desktop' menu, MacOS Catalina 10.15.2 #117

Closed
xraynaud opened this issue Jan 23, 2020 · 8 comments
Closed

Error with 'Show PB for Desktop' menu, MacOS Catalina 10.15.2 #117

xraynaud opened this issue Jan 23, 2020 · 8 comments

Comments

@xraynaud
Copy link

As stated in the title, when I click on 'Show PB for Desktop' menu (top bar), i get the following error message:

A Javascript error occured in the main process
Uncaught exception:
TypeError: getMaineWindow.show is not a function
at click (/Application/PB for Desktop.app/Contents/Resources/app.asar/app/scripts/main-process/menus/tray-menu.js:109:31)
at MenuItem.click (electron/js2C/browser_init.js:1516:9)
at Function.executeCommand (electron/js2C/browser_init.js:1777:13)

🎯 Expected Behaviour

I'm not sure. Show the same window as when clicking on the dock icon ?

👟 Steps to Reproduce (S2R)

  1. Launch MacOS Catalina
  2. Launch PB for Desktop
  3. Click on the top bar PB for Desktop and select 'Show PB for Desktop'

🏡 Environmental Context

App Version
v10.5.0 but also occured in previous version
Installation Type
Setup
MacOS 10.15.2 Catalina

@MockingMagician
Copy link
Contributor

I have same issue on ubuntu 18.10

Capture d’écran de 2020-01-27 13-51-12

:/

@MockingMagician
Copy link
Contributor

Can be fixed with this PR #118

@xraynaud
Copy link
Author

xraynaud commented Feb 7, 2020

@MockingMagician this works. Thanks.

@joeherold
Copy link

same here on 10.15.4

@mutachre
Copy link

mutachre commented Jun 5, 2020

Same here (MacOS Catilina 10.15.5).

2020-06-05_22-46-09 603

@joeherold
Copy link

joeherold commented Jun 6, 2020

You can fix it for yourself as a workaround.
Unpack app.asar and do the PR #118.
Then pack it back to app.asar

npx asar extract app.asar app

npx asar pack app app.asar

@omaishar
Copy link

Same here (Catalina 10.15.6)
image

@sidneys
Copy link
Owner

sidneys commented Aug 20, 2020

@xraynaud @MockingMagician @joeherold @mutachre

Thank you for the report, your work and the related pull request.

This issue should be resolved as per the new release, which was just published, and seems to be a duplicate of identical to #116.

Please review the changes and file a new issue accordingly if the problem should reoccur.

Kind regards,
S

@sidneys sidneys closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants