Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticker preview blurry on certain video or High DPI configurations #5058

Closed
1 task done
knarrff opened this issue Feb 23, 2021 · 13 comments
Closed
1 task done

sticker preview blurry on certain video or High DPI configurations #5058

knarrff opened this issue Feb 23, 2021 · 13 comments

Comments

@knarrff
Copy link

knarrff commented Feb 23, 2021

  • I have searched open and closed issues for duplicates

Bug Description

The sticker selection/preview (when clicking the sticker icon right between the input field and the microphone icon) shows stickers blurry. They show fine after using within the communication context.

This is a recent regression.

Steps to Reproduce

  1. click sticker-icon to open sticker-selection dialog

Actual Result:

blurry images

Expected Result:
not-blurry images

Screenshots

Platform Info

Signal Version:
1.40.1

This was present already in 1.40.0, but is a regression from lot long before that (although I am not sure which version exactly).

Operating System:
Debian Buster

Linked Device Version:

Link to Debug Log

@hiqua
Copy link
Contributor

hiqua commented Feb 23, 2021

Screenshot? Debug log?

@knarrff
Copy link
Author

knarrff commented Feb 23, 2021

@hiqua
Copy link
Contributor

hiqua commented Feb 23, 2021

Do you use HiDPI? Wayland? What's your hardware?

Possibly related:

@knarrff
Copy link
Author

knarrff commented Feb 23, 2021

Indeed, this is connected to DPI settings, on a Lenovo Thinkpad T470p (currently on 1920x1200 external display, and with 2560x1440 internal display).

I am using xfce, and there the setting in

Settings Manager > Appearance > Settings > Fonts > DPI

changes how the icons, and in fact the whole signal content is scaled. What I wonder is: while disabling the DPI setting restores sharp sticker-previews, the stickers in the actual conversation are always sharp, regardless of the DPI setting, and they are also rescaled.

@minosimo
Copy link

minosimo commented Mar 6, 2021

Same issue for me I think, though I'm on windows with a 3440x1440 monitor with no resolution scaling.

image

https://debuglogs.org/c1928c0973fc478568ea9429734a77976ed3e68ba6002742b0673dfd8a1ec910

@jacko0
Copy link

jacko0 commented Mar 8, 2021

Same issue for me using Signal v1.40.1 on Linux Popos.

@scottnonnenberg-signal
Copy link
Contributor

scottnonnenberg-signal commented Mar 8, 2021

Is the emoji picker also blurry? How about when you click on your avatar in the top left? The difference between stickers in the conversation context and the popup appears to be the popup itself.

@jacko0
Copy link

jacko0 commented Mar 9, 2021

Is the emoji picker also blurry? How about when you click on your avatar in the top left? The difference between stickers in the conversation context and the popup appears to the the popup itself.

Hi Scott, strangely the emoji picker is ok, it's just the stickers. My avatar also seems ok.
Once the stickers are in the message itself the sticker are no longer blurry.

@minosimo
Copy link

minosimo commented Mar 9, 2021

Emoji picker is ok. It's difficult to tell for sure, but I think the avatar is ok too.

@scottnonnenberg-signal scottnonnenberg-signal changed the title sticker preview blurry sticker preview blurry on certain video or High DPI configurations Mar 10, 2021
@ghost
Copy link

ghost commented Mar 29, 2021

This is also happening with the reaction viewer. I think I found the problem: Popper's "gpuAcceleration" uses translate3d instead of left and top placement.

transform
image image

left+top
image image

I'm no react, typescript, electron dev, so if there's one here, I think the relevant line is

<Popper placement={popperPlacement}>
.

Maybe it should be <Popper placement={popperPlacement} gpuAcceleration=false> ?

@scottnonnenberg-signal
Copy link
Contributor

@LoveIsGrief Thanks for that deep research!

@stale
Copy link

stale bot commented Sep 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 23, 2021
@stale
Copy link

stale bot commented Sep 30, 2021

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants