Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy Cargo dependencies #408

Closed
paulhauner opened this issue Jun 24, 2019 · 3 comments · Fixed by #456
Closed

Tidy Cargo dependencies #408

paulhauner opened this issue Jun 24, 2019 · 3 comments · Fixed by #456
Labels
good first issue Good for newcomers

Comments

@paulhauner
Copy link
Member

paulhauner commented Jun 24, 2019 •
edited
Loading

Description

Cargo dependencies (Cargo.toml) could use some love.

I suggest we:

  • Remove any unused dependencies (I suspect there are many).
  • Add a caret (^) to deps we want to keep upgrading.
  • Add Cargo.lock to git.
@michaelsproul
Copy link
Member

Deps without any signifier are implicitly taken to be caret dependencies, so bullet (2) may not be necessary: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

@paulhauner paulhauner added this to the v0.0.1 milestone Jun 25, 2019
@paulhauner
Copy link
Member Author

Related to #403

@paulhauner paulhauner added the good first issue Good for newcomers label Jul 4, 2019
@jzaki
Copy link
Contributor

jzaki commented Jul 12, 2019

cargo fix with unused_imports lint

@pawanjay176 pawanjay176 mentioned this issue Jul 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused dependencies pawanjay176/lighthouse
3 participants
@jzaki @michaelsproul @paulhauner