Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Fulcio and Rekor configuration for verification #296

Closed
tetsuo-cpp opened this issue Nov 9, 2022 · 2 comments · Fixed by #323
Closed

Support custom Fulcio and Rekor configuration for verification #296

tetsuo-cpp opened this issue Nov 9, 2022 · 2 comments · Fixed by #323
Assignees
Labels
enhancement New feature or request

Comments

@tetsuo-cpp
Copy link
Collaborator

tetsuo-cpp commented Nov 9, 2022

We're going to need this for sigstore/sigstore-conformance#25 as this is needed to point the client at mock servers during verification. At the moment, we expose the flag but don't support it:

    if args.staging:
        logger.debug("verify: staging instances requested")
        verifier = Verifier.staging()
    elif args.rekor_url == DEFAULT_REKOR_URL:
        verifier = Verifier.production()
    else:
        # TODO: We need CLI flags that allow the user to figure the Fulcio cert chain
        # for verification.
        args._parser.error(
            "Custom Rekor and Fulcio configuration for verification isn't fully supported yet!",
        )
@tetsuo-cpp tetsuo-cpp added the enhancement New feature or request label Nov 9, 2022
@tetsuo-cpp tetsuo-cpp self-assigned this Nov 10, 2022
@woodruffw
Copy link
Member

Let's prioritize this, since it's a conspicuous gap in our functionality. We should see how cosign does this (e.g. which flag they use for the Fulcio cert chain) and try to mirror it 🙂

@tetsuo-cpp
Copy link
Collaborator Author

Sure, working on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants