Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTP password is submitted in GET #35

Closed
lexoyo opened this issue Dec 2, 2017 · 2 comments
Closed

FTP password is submitted in GET #35

lexoyo opened this issue Dec 2, 2017 · 2 comments
Assignees

Comments

@lexoyo
Copy link
Member

lexoyo commented Dec 2, 2017

When the user logs in to FTP or SFTP, the auth page sends the password in get to cloud explorer's router

We should avoid that and use POST data

@SouroucheB SouroucheB self-assigned this Feb 7, 2018
@SouroucheB
Copy link

Could you try the #33 PR please and tell me if the problem still occures ? Because since I redirect the user to a all new URL in case of error, the get parameters no longer appears on my side.

@lexoyo
Copy link
Member Author

lexoyo commented Feb 12, 2018

I believe you did not change this: https://github.com/silexlabs/CloudExplorer2/blob/master/dist/login/ftp_login.html#L10
So ti will still be the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants