prefer-negative-index: Check TypedArray#subarray() (#2237)

sindresorhus · Dec 20, 2023 · 6708a30 · 6708a30
1 parent ec67cbe
commit 6708a30
Show file tree

Hide file tree

Showing 5 changed files with 76 additions and 7 deletions.
diff --git a/docs/rules/prefer-negative-index.md b/docs/rules/prefer-negative-index.md
@@ -19,13 +19,7 @@ Prefer negative index over calculating from `.length` for:
 - [`Array#toSpliced()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/toSpliced)
 - [`Array#with()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/with)
 - [`TypedArray#with()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/with)
-
-<!--
-TODO: Use MDN links when available
-- [`Array#toSpliced()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/toSpliced)
-- [`Array#with()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/with)
-- [`TypedArray#with()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/with)
--->
+- [`TypedArray#subarray()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/subarray)
 
 ## Fail
 

diff --git a/rules/prefer-negative-index.js b/rules/prefer-negative-index.js
@@ -27,6 +27,13 @@ const methods = new Map([
 			]),
 		},
 	],
+	[
+		'subarray',
+		{
+			argumentsIndexes: [0, 1],
+			supportObjects: new Set(typedArray),
+		},
+	],
 	[
 		'splice',
 		{

diff --git a/test/prefer-negative-index.mjs b/test/prefer-negative-index.mjs
@@ -350,6 +350,8 @@ test.snapshot({
 		'String.prototype.with.call(foo, foo.length - 1)',
 		// There is no `TypedArray#toSpliced`
 		'Uint8Array.prototype.toSpliced.call(foo, foo.length - 1)',
+		// There is no `Array#subarray`
+		'Array.prototype.subarray.call(foo, foo.length - 1)',
 	],
 	invalid: [
 		'/**/foo.slice(foo.length - 2, foo.length - 1)',
@@ -372,5 +374,8 @@ test.snapshot({
 		'[].toSpliced.call(foo, foo.length - 3, foo.length - 6)',
 		'foo.with(foo.length - 3, foo.length - 6)',
 		'Array.prototype.with.call(foo, foo.length - 3, foo.length - 6)',
+		'foo.subarray(foo.length - 3, foo.length - 6)',
+		'Uint8Array.prototype.subarray.call(foo, foo.length - 3, foo.length - 6)',
+		'Uint8Array.prototype.subarray.apply(foo, [foo.length - 3, foo.length - 6])',
 	],
 });
diff --git a/test/snapshots/prefer-negative-index.mjs.md b/test/snapshots/prefer-negative-index.mjs.md
@@ -279,3 +279,66 @@ Generated by [AVA](https://avajs.dev).
     > 1 | Array.prototype.with.call(foo, foo.length - 3, foo.length - 6)␊
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer negative index over length minus index for \`with\`.␊
     `
+
+## invalid(13): foo.subarray(foo.length - 3, foo.length - 6)
+
+> Input
+
+    `␊
+      1 | foo.subarray(foo.length - 3, foo.length - 6)␊
+    `
+
+> Output
+
+    `␊
+      1 | foo.subarray(- 3, - 6)␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | foo.subarray(foo.length - 3, foo.length - 6)␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer negative index over length minus index for \`subarray\`.␊
+    `
+
+## invalid(14): Uint8Array.prototype.subarray.call(foo, foo.length - 3, foo.length - 6)
+
+> Input
+
+    `␊
+      1 | Uint8Array.prototype.subarray.call(foo, foo.length - 3, foo.length - 6)␊
+    `
+
+> Output
+
+    `␊
+      1 | Uint8Array.prototype.subarray.call(foo, - 3, - 6)␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | Uint8Array.prototype.subarray.call(foo, foo.length - 3, foo.length - 6)␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer negative index over length minus index for \`subarray\`.␊
+    `
+
+## invalid(15): Uint8Array.prototype.subarray.apply(foo, [foo.length - 3, foo.length - 6])
+
+> Input
+
+    `␊
+      1 | Uint8Array.prototype.subarray.apply(foo, [foo.length - 3, foo.length - 6])␊
+    `
+
+> Output
+
+    `␊
+      1 | Uint8Array.prototype.subarray.apply(foo, [- 3, - 6])␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | Uint8Array.prototype.subarray.apply(foo, [foo.length - 3, foo.length - 6])␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer negative index over length minus index for \`subarray\`.␊
+    `
diff --git a/test/snapshots/prefer-negative-index.mjs.snap b/test/snapshots/prefer-negative-index.mjs.snap