Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.version() to get more accurate name #9

Open
sindresorhus opened this issue Mar 14, 2020 · 2 comments
Open

Use os.version() to get more accurate name #9

sindresorhus opened this issue Mar 14, 2020 · 2 comments

Comments

@sindresorhus
Copy link
Owner

It's only available on Node.js 14, so we must guard its usage.

https://nodejs.org/api/os.html#os_os_version
https://github.com/ehmicky/cross-platform-node-guide/blob/master/docs/7_system/os_identification.md

On Linux, we'll need to do some parsing to get out the actual distro name.

@aiello3-wolai
Copy link

Now older version of macos-release was brokened in macos Ventura 🤷‍♂️ upgrade to latest macos-release or use os.version() please

@micalevisk
Copy link

node14 is not being maintained anymore (see https://github.com/nodejs/Release) so I think that it's a good time to drop node12 support

os-name/package.json

Lines 15 to 17 in ff7af80

"engines": {
"node": "^12.20.0 || ^14.13.1 || >=16.0.0"
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants